Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck at end of stream on IE11 #658

Closed
OrenMe opened this issue Jan 17, 2017 · 5 comments
Closed

Stuck at end of stream on IE11 #658

OrenMe opened this issue Jan 17, 2017 · 5 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@OrenMe
Copy link
Contributor

OrenMe commented Jan 17, 2017

  • What version of Shaka Player are you using?
    2.0.1, 2.0.2, 2.0.3

    • Can you reproduce the issue with our latest release version?
      Yes
    • Can you reproduce the issue with the latest code from master?
      Yes

  • Are you using the demo app or your own custom app?
    Demo app

    • If custom app, can you reproduce the issue using our demo app?

  • What browser and OS are you using?
    IE11 on Win8.1 and Win10

  • What did you do?
    Start playback and wait till end or seek close to end of stream

    • What content did you load?
      Clear dash custom asset and standard

      • If standard demo asset, which one?
        Axinom multi and single period
      • If custom asset, what manifest and license server URIs?
        This test MPD

    • How did you interact with the content, if at all?
      Playback starts autoplay, wait till end or seek to end (close to end)

  • What did you expect to happen?
    Playback ends properly, spinner stops spinning

  • What actually happened?
    Playback stuck on a a second before end with endless spinner

Seems like a regression from 2.0.0 where all links do work.
@TheModMaker TheModMaker self-assigned this Jan 18, 2017
@TheModMaker TheModMaker added the type: bug Something isn't working correctly label Jan 18, 2017
@TheModMaker
Copy link
Contributor

Thanks for the report. This was a problem with IE/Edge's reporting of buffered ranges. They were slightly different when at the end of the stream, so we thought we needed more data. It has been fixed on master.

@OrenMe
Copy link
Contributor Author

OrenMe commented Jan 18, 2017

Thanks @TheModMaker! will you be tagging v2.0.4 version any time soon?

@itaykinnrot
Copy link
Contributor

Thanks!

@joeyparrish
Copy link
Member

I will plan to roll v2.0.4 next week, and this fix will be easy to cherry-pick to the v2.0.x branch.

joeyparrish pushed a commit that referenced this issue Jan 19, 2017
@TheModMaker @joeyparrish
Increase Playhead fudge factor for IE/Edge.
510c0f8 
IE/Edge have problems with reporting the buffered ranges when we get
to the end of the media.  We use a fudge factor to determine if we have
buffered all the content.  It was too small which meant that we would
not detect end of stream correctly.  This increases the fudge factor
so we detect it correctly.

Closes #658

Change-Id: Ie9ecf8fd49eb716ffd8ccd9bcdff53b88356bbfe
@OrenMe
Copy link
Contributor Author

OrenMe commented Jan 21, 2017

Great, thanks @joeyparrish.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@itaykinnrot @TheModMaker @OrenMe @joeyparrish @shaka-bot