Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRM request failed for Oops multi-DRM video #682

Closed
yiningc opened this issue Feb 3, 2017 · 3 comments
Closed

DRM request failed for Oops multi-DRM video #682

yiningc opened this issue Feb 3, 2017 · 3 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@yiningc
Copy link

yiningc commented Feb 3, 2017

Fail to play Oops multi-DRM video in YouTube group in shaka-player-demo-site.
The root cause of this issue is that DRM license request failed in playing this specific video. This issue happen on all OS starting 2/2. There is no problem in playing the other DRM videos on shaka player demo site. Can you fix it?
see attached screenshot.
screenshot 2017-02-02 at 3 42 48 pm
@TheModMaker TheModMaker self-assigned this Feb 3, 2017
@TheModMaker TheModMaker added the type: bug Something isn't working correctly label Feb 3, 2017
@TheModMaker TheModMaker added this to the v2.1.0 milestone Feb 3, 2017
@TheModMaker
Copy link
Contributor

Thanks for noticing this. It has to do with the recent change to only allow using the demo over https. That asset uses an embedded URL for the license server that uses http. This causes problems because the browser rejects mixed content requests.

@joeyparrish
Copy link
Member

Options:

  1. Disable these assets over https
  2. Rewrite the license server URIs (in the custom ContentProtection callback) to be https or schemeless
  3. Get YouTube to update their asset not to specify a scheme or to specify https

I have contacts at YouTube if option 3 seems like the most sensible. Not sure how option 1 would work. Option 2 lets us control our own outcome, so would be most expedient.

shaka-bot pushed a commit that referenced this issue Feb 3, 2017
@TheModMaker
Fix bug when merging DrmInfo structures.
a1b2e53 
The member |initData| may be null or an Array.  When calling
Array.concat with a non-array (e.g. null) it will add a new element.
This results in an array containing null rather than the intended
empty array.

Issue #682

Change-Id: I76b7625a04327f0e236b523d7dc83e08385a7804
shaka-bot pushed a commit that referenced this issue Feb 8, 2017
@TheModMaker
Fix YouTube assets on demo app.
b19cd00 
The YouTube test assets use an embedded URL for the license server.
This URL may actually be http.  This is rejected when using the demo
app over https due to mixed content restrictions in the browser.

Issue #682

Change-Id: Ib7533f7174f4abe25a8810f9b7a9548130ea2876
@TheModMaker
Copy link
Contributor

I just pushed option 2 so the asset is playable now while we wait for YouTube to update their asset.

joeyparrish pushed a commit that referenced this issue Feb 10, 2017
@TheModMaker @joeyparrish
Fix YouTube assets on demo app.
cc95e51 
The YouTube test assets use an embedded URL for the license server.
This URL may actually be http.  This is rejected when using the demo
app over https due to mixed content restrictions in the browser.

Issue #682

Change-Id: Ib7533f7174f4abe25a8810f9b7a9548130ea2876
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @shaka-bot @yiningc