-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issues reported by Lighthouse #905
Comments
Reported by lighthouse Issue #905 Change-Id: Iee9623ab4fabe1432cca72bb9d329e8a07d26bb8
Improvements after fixing render-blocking scripts:
|
Web fonts should change must less often than other resources. Issue #905 Change-Id: Id5a6a64bc997d2ac255222643973bfee2ec0e4ec
Recommended by Lighthouse and by https://developers.google.com/web/updates/2015/10/splashscreen Issue #905 Change-Id: Ie61c9b287d9d8138666a908eb449df214d3d767d
This brings contrast ratios in line with accessibility recommendations for low-vision users. Reported by Lighthouse. Issue #905 Change-Id: Idbf5f1ff253533edd0500c7278a5354f38c04b91
For accessibility reasons, we should allow user scaling. Reported by Lighthouse. Issue #905 Change-Id: I12c47f0fe0300fa24c61e24259eb40da45cbcb9b
Reported by Lighthouse. Issue #905 Change-Id: Ife3c7fe8401b2fb26e78f237144a9baf327e869e
All touch event listeners are now marked explicitly with Issues have already been filed on both Chrome and Lighthouse to fix this and respect |
The only remaining complaint from LightHouse is this one:
This is caused by Google Web Fonts, which seem fundamentally at odds with best practices recommended by Lighthouse. We will continue to use these fonts. |
Lighthouse reports the following issues with the Shaka Player demo:
Manifest does not have icons at least 512px.First meaningful paint: 3,180 msPerceptual Speed Index: 4,532 (target: < 1,250)Reduce render-blocking scripts (these contribute 600 ms to load time)Low contrast elements:<a href="../docs/api/index.html">
<a href="https://github.com/google/shaka-player">
<a href="https://www.npmjs.com/package/shaka-player">
<a href="https://cdnjs.com/libraries/shaka-player">
<button id="loadButton">
[user-scalable="no"] is not used in the element and the [maximum-scale] attribute is not less than 5.Disabling zooming is problematic for users with low vision who rely on screen magnification to properly see the contents of a web page.Failing element:<meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1, maximum-scale=1">
The text was updated successfully, but these errors were encountered: