Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues reported by Lighthouse #905

Closed
joeyparrish opened this issue Jun 22, 2017 · 3 comments
Closed

Resolve issues reported by Lighthouse #905

joeyparrish opened this issue Jun 22, 2017 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

joeyparrish commented Jun 22, 2017

Lighthouse reports the following issues with the Shaka Player demo:

  • Manifest does not have icons at least 512px.
  • First meaningful paint: 3,180 ms
  • Perceptual Speed Index: 4,532 (target: < 1,250)
    • Reduce render-blocking scripts (these contribute 600 ms to load time)
    • Reduce render-blocking stylesheets (these contribute 590 ms to load time)
  • Low contrast elements:
    • <a href="../docs/api/index.html">
    • <a href="https://github.com/google/shaka-player">
    • <a href="https://www.npmjs.com/package/shaka-player">
    • <a href="https://cdnjs.com/libraries/shaka-player">
    • <button id="loadButton">
  • [user-scalable="no"] is not used in the element and the [maximum-scale] attribute is not less than 5.
    • Disabling zooming is problematic for users with low vision who rely on screen magnification to properly see the contents of a web page.
    • Failing element: <meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1, maximum-scale=1">
  • Does not use passive listeners to improve scrolling performance.
@joeyparrish joeyparrish added type: enhancement New feature or request PWA labels Jun 22, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Jun 22, 2017
@joeyparrish joeyparrish self-assigned this Jul 3, 2017
shaka-bot pushed a commit that referenced this issue Oct 2, 2017
Reported by lighthouse

Issue #905

Change-Id: Iee9623ab4fabe1432cca72bb9d329e8a07d26bb8
@joeyparrish
Copy link
Member Author

Improvements after fixing render-blocking scripts:

  • First meaningful paint: 660 ms
  • Perceptual Speed Index: 1,982 (target: < 1,250)

shaka-bot pushed a commit that referenced this issue Oct 2, 2017
Web fonts should change must less often than other resources.

Issue #905

Change-Id: Id5a6a64bc997d2ac255222643973bfee2ec0e4ec
shaka-bot pushed a commit that referenced this issue Oct 2, 2017
Recommended by Lighthouse and by
https://developers.google.com/web/updates/2015/10/splashscreen

Issue #905

Change-Id: Ie61c9b287d9d8138666a908eb449df214d3d767d
shaka-bot pushed a commit that referenced this issue Oct 2, 2017
This brings contrast ratios in line with accessibility recommendations
for low-vision users.

Reported by Lighthouse.

Issue #905

Change-Id: Idbf5f1ff253533edd0500c7278a5354f38c04b91
shaka-bot pushed a commit that referenced this issue Oct 2, 2017
For accessibility reasons, we should allow user scaling.

Reported by Lighthouse.

Issue #905

Change-Id: I12c47f0fe0300fa24c61e24259eb40da45cbcb9b
shaka-bot pushed a commit that referenced this issue Oct 2, 2017
Reported by Lighthouse.

Issue #905

Change-Id: Ife3c7fe8401b2fb26e78f237144a9baf327e869e
@joeyparrish
Copy link
Member Author

All touch event listeners are now marked explicitly with passive: false or passive: true. This does not silence the warning from Lighthouse, though, since one of them is still non-passive. It must remain so, since we call preventDefault() on the event.

Issues have already been filed on both Chrome and Lighthouse to fix this and respect passive: false:

@joeyparrish
Copy link
Member Author

The only remaining complaint from LightHouse is this one:

  • Reduce render-blocking stylesheets (these contribute 590 ms to load time)

This is caused by Google Web Fonts, which seem fundamentally at odds with best practices recommended by Lighthouse. We will continue to use these fonts.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants