fix: gap jumping when gap exists at start position #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before playback starts the video element reports as seeking == true, but because we haven't installed our seek listener yet, the gap controller does not receive the seek event. To work around this, we explicitly tell the gap controller when playback starts so that it knows the startup position, and can synthesize a seek event.
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Jul 3, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
Before playback starts the video element reports as seeking == true, but because we haven't installed our seek listener yet, the gap controller does not receive the seek event. To work around this, we explicitly tell the gap controller when playback starts so that it knows the startup position, and can synthesize a seek event.
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
Before playback starts the video element reports as seeking == true, but because we haven't installed our seek listener yet, the gap controller does not receive the seek event. To work around this, we explicitly tell the gap controller when playback starts so that it knows the startup position, and can synthesize a seek event.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before playback starts the video element reports as seeking == true, but because we haven't installed our seek listener yet, the gap controller does not receive the seek event.
To work around this, we explicitly tell the gap controller when playback starts so that it knows the startup position, and can synthesize a seek event.