Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TTML): Clip to video when extent is not present #6086

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 11, 2024

Fixes #4793

@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround labels Jan 11, 2024
@avelad avelad added this to the v5.0 milestone Jan 11, 2024
@avelad avelad merged commit 2862228 into shaka-project:main Jan 11, 2024
16 of 20 checks passed
@avelad avelad deleted the ttml-wrong-position branch January 12, 2024 09:03
avelad added a commit that referenced this pull request Jan 16, 2024
avelad added a commit that referenced this pull request Jan 16, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMPTE-TT Teletext subtitles are displaying in the wrong position
3 participants