Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set autoCorrectDrift to false by default for low latency streaming #6549

Merged
merged 2 commits into from
May 7, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 7, 2024

No description provided.

@avelad avelad requested a review from theodab May 7, 2024 09:25
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels May 7, 2024
@avelad avelad added this to the v4.9 milestone May 7, 2024
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this, it looks like the jsdoc in the externs for lowLatencyMode mention that it changes inaccurateManifestTolerance and rebufferingGoal, but none of these other config values (segmentPrefetchLimit, updateIntervalSeconds, etc). I assume that it probably has not been kept up-to-date with changes to how LL streaming works.

If we are continuing to add to this list of config value changes, it'd probably be better to stop having a list in the externs at all. Could you change the extern docs to instead simply point people to look at the tutorials? E.g.:

/**
 * @property {boolean} lowLatencyMode
 *   If <code>true</code>, low latency streaming mode is enabled. If
 *   lowLatencyMode is set to true, the default values of some other
 *   configurations are changed; for a full list of these changes, see the "Low
 *   latency streaming" section of the configuration tutorial.
 */

@avelad avelad requested a review from theodab May 7, 2024 09:39
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 3d1c546 into shaka-project:main May 7, 2024
16 checks passed
@avelad avelad deleted the autoCorrectDrift-ll branch May 7, 2024 10:30
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants