ci: Fix workflow request for disabled browsers #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should be able to request a browser explicitly even if it is disabled by default. This fixed the workflow logic that limited this.
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Running https://github.com/shaka-project/shaka-player/actions/runs/9021261305 to verify the change... |
alekzz
approved these changes
May 9, 2024
|
The logic still isn't quite right... The workflow started all default browsers + the disabled one I explicitly requested, instead of only the explicit one. |
joeyparrish
force-pushed
the
fix-ci-disabled-devices
branch
from
e48e5b2
to
0a93509
Compare
|
Apparently fixing that typo fixed the bug... not sure how, but it's working correctly now. |
|
Incremental code coverage: No instrumented code was changed. |
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
You should be able to request a browser explicitly even if it is disabled by default. This fixed the workflow logic that limited this.
joeyparrish
added a commit
that referenced
this pull request
May 31, 2024
You should be able to request a browser explicitly even if it is disabled by default. This fixed the workflow logic that limited this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should be able to request a browser explicitly even if it is disabled by default. This fixed the workflow logic that limited this.