Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix encryption scheme checks in tests #6619

Merged
merged 5 commits into from
May 21, 2024
Merged

test: Fix encryption scheme checks in tests #6619

merged 5 commits into from
May 21, 2024

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented May 16, 2024 •
edited by avelad
Loading

  • Upgrade the encryption scheme polyfill to a version that is resilient against multiple copies (one in compiled shaka library, one in source form).

@joeyparrish
test: Fix encryption scheme checks in tests
246e441 
 - Use the uncompiled encryption scheme polyfill, for consistency, when running unit tests against the uncompiled library source.
 - Upgrade the encryption scheme polyfill to a version that is resilient against multiple copies (one in compiled shaka library, one in source form).
@joeyparrish joeyparrish requested a review from avelad May 16, 2024 05:24
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad
Copy link
Member

avelad commented May 16, 2024

It seems that the new version breaks the DRM in Firefox and does not work.

@avelad avelad added the component: tests The issue involves our automated tests (generally; otherwise use a more specific component) label May 16, 2024
@avelad
Copy link
Member

avelad commented May 16, 2024

Also it produces an error in Tizen:


 Safari 3.0 (Tizen 3.0) ERROR
  An error was thrown in afterAll
  Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
  SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

@avelad avelad added this to the v4.9 milestone May 21, 2024
@avelad
Copy link
Member

avelad commented May 21, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6619

@avelad avelad merged commit bbf54d2 into shaka-project:main May 21, 2024
31 checks passed
@joeyparrish joeyparrish deleted the encryption-scheme branch May 22, 2024 16:19
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
3 participants
@joeyparrish @shaka-bot @avelad