ci: Compute sha1 from ref in advance in lab and screenshot workflows #6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Selenium workflow changes verified. |
avelad
approved these changes
Jun 13, 2024
joeyparrish
force-pushed
the
compute-ref-in-advance
branch
from
6c6083d
to
f15a66d
Compare
|
Incremental code coverage: No instrumented code was changed. |
RedYetiDev
approved these changes
Jun 13, 2024
|
There is an issue with the update-time check in context of the "Update Screenshots -> Selenium Lab" workflow. Working on that this morning. |
…eenshots to selenium-lab-tests instead of pr number
|
Updated to pass the computed sha1 from "Update Screenshots" to "Selenium Lab", so we don't have to compute it twice in that nested scenario. To do this well, I'm migrating the "compute ref" step to an external action (which will go up for review as soon as it's tested and working). |
avelad
approved these changes
Jun 13, 2024
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2024
…6811) Always compute sha1 in lab and screenshot workflows in advance. A symbolic ref can change mid-workflow if the repo changes. Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2024
…6811) Always compute sha1 in lab and screenshot workflows in advance. A symbolic ref can change mid-workflow if the repo changes. Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
avelad
added a commit
to avelad/shaka-player
that referenced
this pull request
Jul 11, 2024
…rkflows (shaka-project#6811)" This reverts commit a472194.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always compute sha1 in lab and screenshot workflows in advance. A symbolic ref can change mid-workflow if the repo changes.