[WIP] Swap alt with redux #59
Conversation
justin808
force-pushed
the
swap-alt-with-redux
branch
from
33a55a3
to
dba3f79
Compare
|
A few observations:
Thanks @alexfedoseev for the help! |
|
Getting there. We've got a few bugs, and we're going to make this work with server side rendering, @alexfedoseev |
This is before changing to use immutable.js
Next issue is:
Uncaught Error: Invariant Violation: The return value of `select` prop
must be an object. Instead received Map { "comments": , "ajaxCounter":
0, "fetchCommentError": "", "submitCommentError": "" }.
Squash merge of #60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
* For the phantomjs issue: ariya/phantomjs#12401 * Still getting a warning iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error: at :4602
justin808
force-pushed
the
swap-alt-with-redux
branch
from
dc23ef2
to
b99f002
Compare
|
NOTE: I rebased this branch on top of master to have a clean history of changes. |
|
|
|
@mapreal19 and I are pairing on this on his branch off of my branch. We decided to have me rebase this one on top of master to have a linear history. So I did @mapreal19 had to do essentially these steps: http://stackoverflow.com/a/18909381/1009332 And then we cherry-picked his change on top of that. Then we ran into an issue with poltergeist not working on his machine. Stay tuned. We're going to pick this up tomorrow. |
|
@mapreal19 Pending:
Future Enhancements:
|
- Added gem "phantomjs" (useful if not installed locally) - Fixed test suite and refactored
…-redux * mapreal19-swap-alt-with-redux-mario: Fixed some issues: resetting the form after submit should reset and focus text not author add error reporting to form and ensure form is reset on succesful save fix ajax loading message
* Still some js linting failures * Run rake lint to see them
|
@mapreal19 @PlasticLizard Looks great! Any volunteer to fix the linting issues? Incidentally, this linting setup is exactly what we use on my other projects. |
- Updated eslint file
…with-redux * mapreal19-swap-alt-with-redux-fix-lints: Fix lint errors
Moving from alt to redux, with immutable.js.
Pending Issues