Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Swap alt with redux #59

Merged
merged 15 commits into from
Aug 27, 2015
Merged

[WIP] Swap alt with redux #59

merged 15 commits into from
Aug 27, 2015

Commits on Aug 22, 2015

  1. commentReducer first version

    This is before changing to use immutable.js
    justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    bbaff22 View commit details
    Browse the repository at this point in the history
  2. WIP for move to redux

    justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    e27b99a View commit details
    Browse the repository at this point in the history
  3. Fixed syntax errors

    Next issue is:
    
    Uncaught Error: Invariant Violation: The return value of `select` prop
    must be an object. Instead received Map { "comments": , "ajaxCounter":
    0, "fetchCommentError": "", "submitCommentError": "" }.
    justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    fcecc0e View commit details
    Browse the repository at this point in the history
  4. Working version with Redux with a few isssues:

    Squash merge of
    #60 from
    @alexfedoseev (thanks!)
    
    1. What should we name the reducer? Seems confusing in terms of how the
    reducer name gets put as part of the state.
    2. Functional issue in that we don't clear out the last name/commment
    after ajax is successful. Seems that we would need to have the component
    state inside of the main store.
    3. Ajax counter to show busy indicator of async in progress might not be
    working.
    4. We should show a simple validation on the server and the display of a
    simple error message on the form.
    justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    d16acc4 View commit details
    Browse the repository at this point in the history
  5. Fixed failing tests

    * For the phantomjs issue: ariya/phantomjs#12401
    * Still getting a warning
      iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
        at :4602
    justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    a55b915 View commit details
    Browse the repository at this point in the history
  6. Fix loggerMiddleware

    alex35mil authored and justin808 committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    b99f002 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b03b9af View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d85bec5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    945f227 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2015

  1. Fixed some issues:

    - Added gem "phantomjs" (useful if not installed locally)
    
    - Fixed test suite and refactored
    mapreal19 committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    78843d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2015

  1. Merge branch 'mapreal19-swap-alt-with-redux-mario' into swap-alt-with…

    …-redux
    
    * mapreal19-swap-alt-with-redux-mario:
      Fixed some issues:
      resetting the form after submit should reset and focus text not author
      add error reporting to form and ensure form is reset on succesful save
      fix ajax loading message
    justin808 committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    400e8b7 View commit details
    Browse the repository at this point in the history
  2. Added explanatory text on behavior, improved linter

    * Still some js linting failures
    * Run
      rake lint
      to see them
    justin808 committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    22d2809 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2015

  1. Fix lint errors

    - Updated eslint file
    mapreal19 committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    f31305c View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2015

  1. Merge branch 'mapreal19-swap-alt-with-redux-fix-lints' into swap-alt-…

    …with-redux
    
    * mapreal19-swap-alt-with-redux-fix-lints:
      Fix lint errors
    justin808 committed Aug 27, 2015
    Configuration menu
    Copy the full SHA
    b4619ca View commit details
    Browse the repository at this point in the history
  2. Updated docs

    justin808 committed Aug 27, 2015
    Configuration menu
    Copy the full SHA
    3628c20 View commit details
    Browse the repository at this point in the history