-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Swap alt with redux #59
Commits on Aug 22, 2015
-
This is before changing to use immutable.js
Configuration menu - View commit details
-
Copy full SHA for bbaff22 - Browse repository at this point
Copy the full SHA bbaff22View commit details -
Configuration menu - View commit details
-
Copy full SHA for e27b99a - Browse repository at this point
Copy the full SHA e27b99aView commit details -
Next issue is: Uncaught Error: Invariant Violation: The return value of `select` prop must be an object. Instead received Map { "comments": , "ajaxCounter": 0, "fetchCommentError": "", "submitCommentError": "" }.
Configuration menu - View commit details
-
Copy full SHA for fcecc0e - Browse repository at this point
Copy the full SHA fcecc0eView commit details -
Working version with Redux with a few isssues:
Squash merge of #60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
Configuration menu - View commit details
-
Copy full SHA for d16acc4 - Browse repository at this point
Copy the full SHA d16acc4View commit details -
* For the phantomjs issue: ariya/phantomjs#12401 * Still getting a warning iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error: at :4602
Configuration menu - View commit details
-
Copy full SHA for a55b915 - Browse repository at this point
Copy the full SHA a55b915View commit details -
Configuration menu - View commit details
-
Copy full SHA for b99f002 - Browse repository at this point
Copy the full SHA b99f002View commit details -
Configuration menu - View commit details
-
Copy full SHA for b03b9af - Browse repository at this point
Copy the full SHA b03b9afView commit details -
Configuration menu - View commit details
-
Copy full SHA for d85bec5 - Browse repository at this point
Copy the full SHA d85bec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 945f227 - Browse repository at this point
Copy the full SHA 945f227View commit details
Commits on Aug 24, 2015
-
- Added gem "phantomjs" (useful if not installed locally) - Fixed test suite and refactored
Configuration menu - View commit details
-
Copy full SHA for 78843d2 - Browse repository at this point
Copy the full SHA 78843d2View commit details
Commits on Aug 25, 2015
-
Merge branch 'mapreal19-swap-alt-with-redux-mario' into swap-alt-with…
…-redux * mapreal19-swap-alt-with-redux-mario: Fixed some issues: resetting the form after submit should reset and focus text not author add error reporting to form and ensure form is reset on succesful save fix ajax loading message
Configuration menu - View commit details
-
Copy full SHA for 400e8b7 - Browse repository at this point
Copy the full SHA 400e8b7View commit details -
Added explanatory text on behavior, improved linter
* Still some js linting failures * Run rake lint to see them
Configuration menu - View commit details
-
Copy full SHA for 22d2809 - Browse repository at this point
Copy the full SHA 22d2809View commit details
Commits on Aug 26, 2015
-
Configuration menu - View commit details
-
Copy full SHA for f31305c - Browse repository at this point
Copy the full SHA f31305cView commit details
Commits on Aug 27, 2015
-
Merge branch 'mapreal19-swap-alt-with-redux-fix-lints' into swap-alt-…
…with-redux * mapreal19-swap-alt-with-redux-fix-lints: Fix lint errors
Configuration menu - View commit details
-
Copy full SHA for b4619ca - Browse repository at this point
Copy the full SHA b4619caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3628c20 - Browse repository at this point
Copy the full SHA 3628c20View commit details