Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset safe directory permissions before fetching theme submodules #52

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Reset safe directory permissions before fetching theme submodules #52

merged 1 commit into from
Jan 30, 2023

Conversation

Wtoll
Copy link
Contributor

@Wtoll Wtoll commented Jan 30, 2023

Fixes #50

I found in testing that simply specifying "/github/workspace" as in #51 was not sufficient for situations where additional submodules were fetched, so this PR supplies permissions for all directories instead.

@Wtoll
Copy link
Contributor Author

Wtoll commented Jan 30, 2023

Tested in deployment of my personal site (Wtoll/Website) utilizing submodules for themes. See this log.

@shalzz shalzz merged commit 70a101a into shalzz:master Jan 30, 2023
@shalzz
Copy link
Owner

shalzz commented Jan 30, 2023

Thanks! Merged.

mefool added a commit to mefool/mefool.github.io that referenced this pull request Jan 30, 2023
@tieje tieje mentioned this pull request Jan 30, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Feb 7, 2023
This is supposed to be fixed in `master`, but for some reason doesn't work...

See shalzz/zola-deploy-action#52 for details.
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Feb 7, 2023
This is supposed to be fixed in `master`, but for some reason doesn't work...

See shalzz/zola-deploy-action#52 for details.
Daquisu added a commit to Daquisu/zola that referenced this pull request Feb 12, 2023
Old version was not able to fetch theme submodules: shalzz/zola-deploy-action#50

It was fixed in the following PR: shalzz/zola-deploy-action#52

This commit changes the docs to match the newest  `zola-deploy-action`  version, without the problem above.
Keats pushed a commit to getzola/zola that referenced this pull request Feb 13, 2023
Old version was not able to fetch theme submodules: shalzz/zola-deploy-action#50

It was fixed in the following PR: shalzz/zola-deploy-action#52

This commit changes the docs to match the newest  `zola-deploy-action`  version, without the problem above.
Newbytee pushed a commit to Newbytee/zola that referenced this pull request Feb 16, 2023
Old version was not able to fetch theme submodules: shalzz/zola-deploy-action#50

It was fixed in the following PR: shalzz/zola-deploy-action#52

This commit changes the docs to match the newest  `zola-deploy-action`  version, without the problem above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error when trying to fetch theme submodules
2 participants