Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "download" module version #36

Merged
merged 2 commits into from
Dec 10, 2014
Merged

Update "download" module version #36

merged 2 commits into from
Dec 10, 2014

Conversation

msieurtoph
Copy link
Contributor

Fixing the installation with url like : "http://localhost:xxxx/*_/_.zip"

Fixing the installation with url like : "http:://localhost:xxxx/**/*.zip"
@shama
Copy link
Owner

shama commented Dec 9, 2014

Thanks for the PR! Could you update the range to >=3.1.0 <3.2.0-0?

I prefer explicit version ranges as the spec for npm's ^ can (and has before) changed it's meaning. Also ^3.2.0 is semantically correct but the community doesn't always follow suit. It is common for authors to publish breaking changes on minor versions due to old habits that ~ set for people.

See https://github.com/rvagg/npm-explicit-deps for more reasons. Thanks!

@msieurtoph
Copy link
Contributor Author

Done! ;)

shama added a commit that referenced this pull request Dec 10, 2014
Update "download" module version
@shama shama merged commit ad0bb7e into shama:master Dec 10, 2014
@shama
Copy link
Owner

shama commented Dec 10, 2014

Thanks!

@msieurtoph
Copy link
Contributor Author

Thx to you for having done that quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants