feat: add dtls #35
Closed
feat: add dtls #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK ta, this will be great addition to the package. |
JKRhb
reviewed
Jan 2, 2022
Comment on lines
+21
to
+22
| dtls: | ||
| path: /home/sorunome/repos/famedly/frontend/dtls |
There was a problem hiding this comment.
@Sorunome Thank you for providing this PR! I guess now that the dtls package is published on pub.dev this could be replaced? :)
Suggested change
| dtls: | |
| path: /home/sorunome/repos/famedly/frontend/dtls | |
| dtls: ^0.1.0 |
|
Absolutely! There is another thing needed to do to get certificate verification on android and iOS working, though, but between holidays and shifting priorities at work I haven't had time for that yet, should be able to get to it soon, though!
2. 1. 2022 1:55:02 Jan Romann ***@***.***>:
… ***@***.**** commented on this pull request.
----------------------------------------
In pubspec.yaml[#35 (comment)]:
> + dtls:
+ path: /home/sorunome/repos/famedly/frontend/dtls
@Sorunome[https://github.com/Sorunome] Thank you for providing this PR! I guess now that the *dtls* package is published on pub.dev[https://pub.dev/packages/dtls] this could be replaced? :)
⬇️ Suggested change
- dtls:
- path: /home/sorunome/repos/famedly/frontend/dtls
+ dtls: ^0.1.0
—
Reply to this email directly, view it on GitHub[#35 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVBUJ4VIM5PKTQCL7RLUT6O6JANCNFSM5FX2OOAA].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you were mentioned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Sledovací obrázek][https://github.com/notifications/beacon/AASSEVGPDKVN7WSKTVBNRPTUT6O6JA5CNFSM5FX2OOAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGI2Y7LA.gif]
|
|
Has this feature development stalled or is it still in progress? |
|
sadly it is currently stale due to a prolonged sick leave on my side...yes, a few months :/
9. 3. 2022 10:34:46 SimonH-Zuma ***@***.***>:
… Has this feature development stalled or is it still in progress?
—
Reply to this email directly, view it on GitHub[#35 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVG4QT5HW22PQIDSFTDU7BWDBANCNFSM5FX2OOAA].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you were mentioned.[Sledovací obrázek][https://github.com/notifications/beacon/AASSEVD2LQLPYE4DF64EH63U7BWDBA5CNFSM5FX2OOAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH5L7CKY.gif]
|
|
Sorry to hear about this and I hope you're feeling better. I'm using the CoAP dart package and now need to use CoAP with DTLS. So if there's anything I can do to assist this development then I'd be happy to help (though I know nothing of the nuts and bolts of DTLS currently) |
|
it should be basically functional i you drop in the dtls pacjage from pub.dev, error handeling is basically non-existant yet, which is why this pr is still wip
9. 3. 2022 13:12:19 SimonH-Zuma ***@***.***>:
… Sorry to hear about this and I hope you're feeling better.
I'm using the CoAP dart package and now need to use CoAP with DTLS. So if there's anything I can do to assist this development then I'd be happy to help (though I know nothing of the nuts and bolts of DTLS currently)
—
Reply to this email directly, view it on GitHub[#35 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVFUJYN367NFFYQGM2TU7CIR7ANCNFSM5FX2OOAA].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you were mentioned.[Sledovací obrázek][https://github.com/notifications/beacon/AASSEVG4RDLBUTRR66K6SFLU7CIR7A5CNFSM5FX2OOAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH5M63XQ.gif]
|
|
Ok. I shall experiment with that. Thank you for pointing the way 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DTLS support. It currently relies on an internal, not yet published package which implements openssl ffi bindings so that it is possible to use dtls in dart.
This PR is WIP to track the progress and signalize that i am working on it. Discussions on how to expose the option are welcome, too; currently it is only exposed via the
DefaultCoapConfig.coapgetter.Implements #27