feat: add option to pool udp connections by client instance #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorunome
force-pushed
the
soru/namespace
branch
3 times, most recently
from
54c30ab
to
2be41d8
Compare
Sorunome
force-pushed
the
soru/namespace
branch
2 times, most recently
from
de6aa16
to
cc2dbb3
Compare
|
Yes this is OK, I think we should add a log line to the client that just prints what namespace the client object is using, it will help with fault analysis when a user submits logs. This only needs doing once, or maybe at strategic log lines like send/receive etc. as you think fit. |
Sorunome
force-pushed
the
soru/namespace
branch
from
cc2dbb3
to
4f46d2d
Compare
|
Done! Added a log line to |
|
Thanks, package re published at version 3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #36, Fixes #29
This adds the config option
poolUdpConnectionsByClientto the config. the default isfalse, meaning current behaviour: if you create more client objects, then they will re-use all those udp connections, provided the remote address is the same. If you set it totruethen it is namespaced by client object.