Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Readme examples missing comma #11

Closed
guyluz11 opened this issue Jul 23, 2022 · 2 comments
Closed

[BUG] Readme examples missing comma #11

guyluz11 opened this issue Jul 23, 2022 · 2 comments
Assignees
@guyluz11
Labels
bug Something isn't working

Comments

@guyluz11
Copy link
Contributor

guyluz11 commented Jul 23, 2022 •
edited
Loading

Describe the bug
In the readme file the examples missing a , comma.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/shan-shaji/day_picker/edit/master/README.md

Screenshots

First place:

image

Second place:

image
@guyluz11 guyluz11 added the bug Something isn't working label Jul 23, 2022
@shan-shaji
Copy link
Owner

@guyluz11 , Thanks for opening an issue. Would you mind working on this?

@guyluz11
Copy link
Contributor Author

Sure Assignees that to me

guyluz11 added a commit to guyluz11/day_picker that referenced this issue Jul 23, 2022
@guyluz11
Fixed readme missing commas (shan-shaji#11)
c9d7f95
shan-shaji pushed a commit that referenced this issue Jul 23, 2022
@guyluz11
Fixed readme missing commas (#11) (#12)
c92c5e2
shan-shaji pushed a commit that referenced this issue May 10, 2023
@guyluz11
#15 adding set days function (#16)
2acca66 
* Fixed readme missing commas (#11)

* Added option to set days after SelectWeekDays got created

* Changed github action flutter version to latest stable

* Fix logic bug for setDaysState

---------

Co-authored-by: Guy Luz <guy@remepy.com>
shan-shaji pushed a commit that referenced this issue Jul 13, 2023
@guyluz11
Adding more coloring options (#19)
b01e3ed 
* Fixed readme missing commas (#11)

* Added option to change more selected unselected day colors

* Reverted background color for first selected weeks day

* Improve code readability

---------

Co-authored-by: Guy Luz <guy@remepy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyluz11 guyluz11

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guyluz11 @shan-shaji