Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one repo builds packages and one fails #94

Closed
JimT787 opened this issue Feb 13, 2023 · 3 comments
Closed

one repo builds packages and one fails #94

JimT787 opened this issue Feb 13, 2023 · 3 comments

Comments

@JimT787
Copy link

JimT787 commented Feb 13, 2023

Wondering if there is a simple answer.

I am trying to use private repositories that publish releases to public repository.

I have a test app that did fine and another that is just failing for some reason. I have followed the same process in each application with the github actions file. Have Github tokens as secrets stored in the private repository.

I included screenshots of the build process. Both apps build, but the jdeploy process has two different results. Seems to be related to to "jdeploy@4.0.8"

One build process doesn't see it so provides a Warning, then downloads it and continues. The other build process doesn't see it and quits instead of downloading and installing it.

Thanks for your help!

Failed
Passed

@shannah
Copy link
Owner

shannah commented Feb 13, 2023

Does the repo have a package.json file?

@JimT787
Copy link
Author

JimT787 commented Feb 13, 2023

It did not--I was down the path of Github versus NPM and for some reason thought I didn't need it if I did it that way--brain is just drained after many days of working on this.

Thank you for your quick reply!

I added the package.json and it worked as advertised! I am very happy to have it working. It saves me getting another computer and I signed up for your substack to toss you some bucks. Really appreciate the effort you put into this--it looks like it will work out very nicely for me and my users. It's just a hobby level program I do as a volunteer project and jDeploy will help out greatly with this project.

@shannah
Copy link
Owner

shannah commented Feb 13, 2023

Great! Glad to hear you got it working.

Thanks so much for the subscription. It is much appreciated and adds motivation to continue making the project better.

@shannah shannah closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants