Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor compose files + user parameter removal #91

Merged
merged 2 commits into from
Jul 13, 2023
Merged

refactor compose files + user parameter removal #91

merged 2 commits into from
Jul 13, 2023

Conversation

shantanoo-desai
Copy link
Owner

@shantanoo-desai
refactor(compose): replace deprecated security_opt value
7564d8c 
Replace `:` separator with `=` for all elements of `security_opt`
parameter list

close #87

Signed-off-by: Shantanoo 'Shan' Desai <shantanoo.desai@gmail.com>
@shantanoo-desai
refactor: remove user / user ID from Compose / Config
3b0f373 
`user` when set to `ansible_user_id` which does not match the
container's user id causes startup failures. `user` was initially
used to allow Docker Secrets to be readable; which is since solved
through #79. This patch removes:

- `user` parameter in all service compose files (closes #88)
- in the main configuration file for Komponist (closes #89)
- user ID generation in the TUI bash script (closes #90)

Signed-off-by: Shantanoo 'Shan' Desai <shantanoo.desai@gmail.com>
@shantanoo-desai shantanoo-desai added node-red All activities for Node-RED specific development docker-compose All activities related to docker compose files / templates mosquitto-mqtt All activities for Mosquitto MQTT Broker files / templates influxdbv2 All activities related to InfluxDBv2 TSDB grafana All activities related to Grafana Monitoring TUI Terminal UI for Komponist labels Jul 13, 2023
@shantanoo-desai shantanoo-desai self-assigned this Jul 13, 2023
@shantanoo-desai shantanoo-desai merged commit 306ca13 into main Jul 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shantanoo-desai shantanoo-desai

Labels
docker-compose All activities related to docker compose files / templates grafana All activities related to Grafana Monitoring influxdbv2 All activities related to InfluxDBv2 TSDB mosquitto-mqtt All activities for Mosquitto MQTT Broker files / templates node-red All activities for Node-RED specific development TUI Terminal UI for Komponist
Projects
komponist
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker] Replace : separator with = for Security Options for all services
1 participant
@shantanoo-desai