Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for packaging #1

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Adding support for packaging #1

merged 1 commit into from
Aug 6, 2021

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Feb 19, 2021 •
edited
Loading

Adding support for packaging.
Addition of the following packaging / build parameters :

  • Repo
  • Branch / Tag
  • PR ID
  • Local directory

Takes between 30-40 min to build

mbx build apache/cloudstack 4.11 centos6     [branch]
mbx build apache/cloudstack 4.15.0.0 debian  [tag]
mbx build apache/cloudstack 4716 debian      [PR]

/export/testing/builds/
├── 4.11
│   └── centos6
│       ├── cloudstack-agent-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-baremetal-agent-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-cli-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-common-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-integration-tests-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-management-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-marvin-4.11.4.0-1.el6.x86_64.rpm
│       ├── cloudstack-mysql-ha-4.11.4.0-1.el6.x86_64.rpm
│       └── cloudstack-usage-4.11.4.0-1.el6.x86_64.rpm
├── 4.15.0.0
│   └── debian
│       ├── cloudstack-agent_4.15.0.0_all.deb
│       ├── cloudstack-common_4.15.0.0_all.deb
│       ├── cloudstack-docs_4.15.0.0_all.deb
│       ├── cloudstack-integration-tests_4.15.0.0_all.deb
│       ├── cloudstack-management_4.15.0.0_all.deb
│       ├── cloudstack-marvin_4.15.0.0_all.deb
│       └── cloudstack-usage_4.15.0.0_all.deb
├── master
│   └── centos8
│       ├── cloudstack-agent-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-baremetal-agent-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-cli-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-common-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-integration-tests-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-management-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-marvin-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-mysql-ha-4.16.0.0-1.el8.x86_64.rpm
│       ├── cloudstack-ui-4.16.0.0-1.el8.x86_64.rpm
│       └── cloudstack-usage-4.16.0.0-1.el8.x86_64.rpm
└── pr
    └── 4716
        └── debian
            ├── cloudstack-agent_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-common_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-docs_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-integration-tests_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-management_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-marvin_4.15.1.0-SNAPSHOT_all.deb
            ├── cloudstack-ui_4.15.1.0-SNAPSHOT_all.deb
            └── cloudstack-usage_4.15.1.0-SNAPSHOT_all.deb

rohityadavcloud
rohityadavcloud reviewed Feb 19, 2021
View reviewed changes
files/build.sh Outdated Show resolved Hide resolved
rohityadavcloud
rohityadavcloud reviewed Feb 19, 2021
View reviewed changes
files/build.sh Outdated Show resolved Hide resolved
@rohityadavcloud
Copy link
Member

I was thinking the command/usage would be something like:

mbx build <repo url or PR url> <tag|sha|branch name> <option distro: centos6/7/8/debian otherwise builds for all by default>

@davidjumani davidjumani force-pushed the add-packaging branch 2 times, most recently from 8bcb871 to cd8556b Compare February 22, 2021 09:56
rohityadavcloud
rohityadavcloud reviewed Feb 22, 2021
View reviewed changes
files/build.sh Outdated Show resolved Hide resolved
rohityadavcloud
rohityadavcloud reviewed Feb 22, 2021
View reviewed changes
mbx Outdated Show resolved Hide resolved
@rohityadavcloud rohityadavcloud mentioned this pull request Feb 22, 2021
Closed
@davidjumani davidjumani marked this pull request as ready for review February 22, 2021 13:13
@davidjumani davidjumani changed the title [WIP] Adding support for packaging Adding support for packaging Feb 23, 2021
@rohityadavcloud
Copy link
Member

@davidjumani is this good for testing, does it work?

@davidjumani
Copy link
Contributor Author

@rhtyd Yes working

rp-
rp- reviewed Jul 14, 2021
View reviewed changes
mbx
[[ $tag =~ $re ]] && pr_id=$tag && output_dir="${output_dir:=/export/testing/builds/pr/$tag/$distro}"
output_dir="${output_dir:=/export/testing/builds/$tag/$distro}"

ROOT=`pwd`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should probably removed, otherwise mbx build will only work if you run it from /export/monkeybox

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani can you review/fix this?

Copy link
Contributor Author

@davidjumani davidjumani Aug 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works irrespective of the current directory, just used here since we need to cd and then get back to the user's directory

@rohityadavcloud
Copy link
Member

@davidjumani what is the 'local directory' task, is to publish the repos locally?

@davidjumani
Copy link
Contributor Author

It's to use a local directory containing the acs repo in which the user might have made changes that are not yet pushed to any branch but can be skipped for now

@rohityadavcloud rohityadavcloud merged commit eefc130 into main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud left review comments

@rp- rp- rp- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjumani @rohityadavcloud @rp-