Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxInstances Annotation produces error #27

Closed
PandyLegend opened this issue Apr 29, 2020 · 3 comments
Closed

maxInstances Annotation produces error #27

PandyLegend opened this issue Apr 29, 2020 · 3 comments

Comments

@PandyLegend
Copy link
Contributor

When using maxInstances in the annotation, such as @CronJob("*\/5 * * * *",maxInstances=2)
upon running php bin/console shapecode:cron:scan I get the following error:

In Annotation.php line 75:

Unknown property 'maxInstances' on annotation 'Shapecode\Bundle\CronBundle
Annotation\CronJob'.

As far as I can tell, the code in src/Annotation/CronJob.php is correct and I even get the typehint for maxInstances in PHPStorm.
As this doesn't appear in the docs, it's possible that I am doing something wrong - if so, could you advise and update the docs accordingly?
Thanks
PandyLegend added a commit to PandyLegend/cron-bundle that referenced this issue Apr 29, 2020
@PandyLegend
Changed 'int' to 'integer' in CronJob.php
8425196 
Resolves shapecode#27
PandyLegend added a commit to PandyLegend/cron-bundle that referenced this issue Apr 29, 2020
@PandyLegend
Changed $maxInstances from private to public in CronJob.php
4db3cb2 
Resolves shapecode#27
PandyLegend added a commit to PandyLegend/cron-bundle that referenced this issue Apr 30, 2020
@PandyLegend
Changed $maxInstances from private to public in CronJob.php
c0fc96f 
Resolves shapecode#27
@PandyLegend PandyLegend mentioned this issue Apr 30, 2020
Closed
@nicklog
Copy link
Contributor

nicklog commented Apr 30, 2020

Thanks for your PR. I'll take a look by time.

@nicklog
Copy link
Contributor

nicklog commented May 2, 2020

Test it if you want and then close this issue. thank you :)

@PandyLegend
Copy link
Contributor Author

All seems good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed $maxInstances from private to public in CronJob.php PandyLegend/cron-bundle
2 participants
@nicklog @PandyLegend