Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update 0x and zerion to use proxy api #5950

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

Description

Use proxy api for 0x and zerion

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5703

Risk

  • None

Testing

  • Zerion requests still succeed
  • 0x requests still succeed

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner January 5, 2024 22:29
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐
Tested locally:

  • 0x calls are happy
Screenshot 2024-01-06 at 23 17 16
  • Zerion calls are happy
Screenshot 2024-01-06 at 23 16 52

@0xApotheosis 0xApotheosis self-assigned this Jan 8, 2024
@0xApotheosis 0xApotheosis enabled auto-merge (squash) January 8, 2024 00:14
@0xApotheosis 0xApotheosis merged commit afe222f into develop Jan 8, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the api-proxy branch January 8, 2024 00:18
baseUrlFromChainId: vi.fn(() => 'https://0x.shapeshift.com/ethereum'),
}
})
vi.mock('../../utils/helpers/helpers')
Copy link
Contributor

@gomesalexandre gomesalexandre Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xApotheosis I believe we can and should remove this one πŸ‘€

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre mentioned this pull request Jan 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless reverse proxy implementation
3 participants