chore: split WallectConnect projects #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Tested locally:
- WC wallet option is still happy
- WC to dApps is still happy
1inch dApp Swap Tx:
https://gnosisscan.io/tx/0x48c3eee27400f1e12b072ecb94e0a70fc0e8f98bfdbe9654f31de178790b0cf9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits our wallet connect projects into two (wallet and dApp), following a discussion with the wallet connect team:
New config:
f58c0242def84c3b9befe9b1e6086bbda28cc4392a374056df13372b666190a0Pull Request Type
Issue (if applicable)
Closes #5942
Risk
Small risk to the current WalletConnect wallet and dApp functionality.
Testing
Ensure WalletConnect wallet and dApp functionally still works as expected.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A