Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable trade preview while custom recipient is editing #6132

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 6, 2024

Description

Follows-up on #6072, tackling the issue spotted by @0xApotheosis in #6072 (review):

🤔 Probably not a blocker, as we no longer crash in this state, but we still don't ensure the "Preview Trade" button is disabled whilst manually editing the address

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

Low to none, ensure it's still possible to continue to trade confirm both with the flag on and off

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • See risks

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

isEditing.mov

Copy link
Contributor Author

gomesalexandre commented Feb 6, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre force-pushed the feat_manual_recipient_disable_while_editin branch from 745f0f6 to 52b4828 Compare February 6, 2024 10:30
@gomesalexandre gomesalexandre marked this pull request as ready for review February 6, 2024 10:33
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 6, 2024 10:33
@gomesalexandre gomesalexandre merged commit 714be23 into develop Feb 6, 2024
4 checks passed
@gomesalexandre gomesalexandre deleted the feat_manual_recipient_disable_while_editin branch February 6, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants