Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display thorchain and cosmos account label as the shortened address #6839

Merged
merged 1 commit into from
May 7, 2024

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented May 7, 2024

Description

Updates the account label for cosmos and thorchain accounts to be the shortened "first four, last four" address, as is done with EVMs. This change was triggered by #6837 and expanded to be app-wide since it has actual utility UX-wise (see screenshots)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6837

Risk

High Risk PRs Require 2 approvals

Low risk, only related to account labels which are presumably already wired up correctly.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Check account labels around the app are correct and that displaying thorchain and cosmos account labels as a shortened address makes sense. So far all known occurrences or thorchain and cosmos account labels DO make sense to be displayed as an address (see screenshots).

Engineering

Operations

Screenshots (if applicable)

Import accounts, borked account label:

Updated to behave like single-address accounts (EVMs):


Account selection in swapper, prod:

Updated to behave like single-address accounts (EVMs):


EVM accounts have address in back button:

Thorchain / Cosmos do not:

Fixed:

@woodenfurniture woodenfurniture marked this pull request as ready for review May 7, 2024 02:43
@woodenfurniture woodenfurniture requested a review from a team as a code owner May 7, 2024 02:43
@0xApotheosis 0xApotheosis self-assigned this May 7, 2024
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense.

Checked all instances I could find, and this does what it says on the box without causing weird label issues anywhere 🙏

@0xApotheosis 0xApotheosis merged commit da0111d into develop May 7, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the fix-account-label branch May 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show addresses for thorchain and cosmos when importing accounts
2 participants