Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env endpoint for server #8

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

Spazzy757
Copy link
Contributor

@Spazzy757 Spazzy757 commented Jun 9, 2023

Changelog

  • adds a env to the /info endpoint for the server

Fixes: #7

Copy link
Owner

@sharat87 sharat87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things in addition to merging this with /info, and we should be good!

bun/bun.go Outdated Show resolved Hide resolved
bun/bun.go Outdated Show resolved Hide resolved
bun/bun.go Outdated Show resolved Hide resolved
bun/bun.go Outdated Show resolved Hide resolved
bun/bun.go Show resolved Hide resolved
@Spazzy757 Spazzy757 force-pushed the master branch 2 times, most recently from 065b685 to ee8c708 Compare June 19, 2023 08:04
@Spazzy757 Spazzy757 requested a review from sharat87 June 19, 2023 08:10
Copy link
Owner

@sharat87 sharat87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Once we revert the changes to import order, we can merge this in. Thanks!

Signed-off-by: Spazzy <brendankamp757@gmail.com>
@sharat87
Copy link
Owner

Thank you @Spazzy757, very appreciate you engaging in the discussion to get this merged. Thank you so much for your contribution! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: endpoint to pull environment
2 participants