Use @teamwork/websocket-json-stream in textarea example #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that #283 has been merged and released in v1.0.0-beta.22, I can verify that this works well and does not suffer from the original bug observed (#282). Just now verified locally with fresh |
ericyhwang
approved these changes
Apr 17, 2019
|
Thanks for checking that it's all working now! I agree with making the changes elsewhere, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280
Since the example in README.md uses @teamwork/websocket-json-stream, I thought it would make sense to also have the code examples use it.
There is a slight issue at the moment with this change, I'm not sure why. It's documented here Teamwork/websocket-json-stream: Error with ShareDB Usage.
If we proress here, I'd like to also propose updating the other examples in the same way, then once they work, update all their dependencies generally, which are getting out of date.
Related to discussion here #275