Fix test for sync unsubscribe, to work with real DB (sharedb-mongo) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: sharedb's tests get included and run inside of sharedb-mongo as well.
share/sharedb-mongo#88 revealed that the new test case added in #358 for "unsubscribes synchronously" doesn't work in sharedb-mongo's test suite, which has a DB connection per test case and closes that connection after the test. The second client's op submission then results in:
This PR moves the
done()in the test to after the second client has successfully submitted. If the first client is incorrectly still subscribed and receives the op through a subscription, that will still correctly cause the test case to fail with "Already closed (and Mocha's done() called multiple times)".