Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix error handling in _fetchCreateOpVersion() #660

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

alecgibson
Copy link
Collaborator

We're currently not returning errors from the database adapter if there are issues fetching the committed op, because of a code typo.

This change adds coverage for this case and fixes the bug.

@alecgibson alecgibson force-pushed the create-error-fix branch 2 times, most recently from 7378ab7 to c8de10c Compare May 29, 2024 07:44
@alecgibson
Copy link
Collaborator Author

Flaky build should be fixed in #662

We're currently not returning errors from the database adapter if there
are issues fetching the committed op, because of a code typo.

This change adds coverage for this case and fixes the bug.
@coveralls
Copy link

Coverage Status

coverage: 97.445%. remained the same
when pulling b539608 on create-error-fix
into 3cdecf4 on master.

@alecgibson alecgibson merged commit d6fbaef into master Jun 11, 2024
8 checks passed
@alecgibson alecgibson deleted the create-error-fix branch June 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants