✅ Move projections test inside getQuery check
#664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
get-query-fix
branch
2 times, most recently
from
97dc188
to
03301d6
Compare
alecgibson
force-pushed
the
get-query-fix
branch
from
03301d6
to
81b6d2a
Compare
ericyhwang
approved these changes
Jun 11, 2024
The `getQuery` test option is optional, but the projections tests try to run regardless of whether it's set. This change moves it inside the guard for this option.
alecgibson
force-pushed
the
get-query-fix
branch
from
81b6d2a
to
38d44fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getQuerytest option is optional, but the projections tests try to run regardless of whether it's set.This change moves it inside the guard for this option.