Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Dark+ VS Code Theme #1588

Closed
David-Else opened this issue Mar 16, 2021 · 2 comments · Fixed by #1598
Closed

Include Dark+ VS Code Theme #1588

David-Else opened this issue Mar 16, 2021 · 2 comments · Fixed by #1598
Labels
feature-request New feature or request

Comments

@David-Else
Copy link

It ships as default in VS Code and would be great to include https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/themes/dark_plus.json

Is there a compatible version someone has done?
@David-Else David-Else added the feature-request New feature or request label Mar 16, 2021
@eoan-ermine eoan-ermine mentioned this issue Mar 24, 2021
Merged
@vatosarmat
Copy link

vatosarmat commented May 2, 2021 •
edited
Loading

VScode theme is good to have but this particular implementation looks abandoned and unmaintained

@David-Else
Copy link
Author

@vatosarmat It looks really good to me. I don' think there is anything to add or anything broken I can see. Here is a comparison of VS Code vs bat with Visual Studio Code Dark+ Color Scheme for Sublime Text 3:

(there are always some differences from the actual VS Code syntax highlighting in all emulating themes, but it doesn't matter)
code
bat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Dark+ theme eoan-ermine/bat
2 participants
@David-Else @vatosarmat