Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xaml to the list of known formats #1590

Closed
jftuga opened this issue Mar 18, 2021 · 4 comments · Fixed by #1655
Closed

Add xaml to the list of known formats #1590

jftuga opened this issue Mar 18, 2021 · 4 comments · Fixed by #1655
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@jftuga
Copy link

jftuga commented Mar 18, 2021

.xaml files are used by Microsoft Visual Studio, C# to create GUI widget layouts. It can use the same output format as .xml files.

See also: https://en.wikipedia.org/wiki/Extensible_Application_Markup_Language

I am currently using:

bat -l xml MainWindow.xaml

It would be nice if the -l xml was implied for .xaml files. If you this is acceptable, I can submit a PR.

Thanks.

@jftuga jftuga added the feature-request New feature or request label Mar 18, 2021
@keith-hall
Copy link
Collaborator

Thanks for the feedback. I guess ideally this change would be made at https://github.com/sublimehq/Packages/blob/7b4df489cac59cfe0fe60927b53c9d720040d7f4/XML/XML.sublime-syntax#L54-L77, but as the library we use for syntax highlighting doesn't support the latest features used in that repository, I believe the choices we have are to either have a patch to the syntax (like those in https://github.com/sharkdp/bat/tree/master/assets/patches), or include it in the syntax mappings. I'd personally go with a patch, not sure how others feel about it? :)

@jftuga
Copy link
Author

jftuga commented Mar 18, 2021

@keith-hall

I'd personally go with a patch, not sure how others feel about it? :)

I've never looked at the bat source before so I would have no idea about this and am curious as why you would choose this method. Also, upon further thought, I am not sure that I could provide a PR as I have never programmed in Rust before.

@sharkdp
Copy link
Owner

sharkdp commented May 12, 2021

I'm okay with the patch solution or a manual entry in the syntax mappings.

@sharkdp
Copy link
Owner

sharkdp commented Jul 13, 2021

Fixed in v0.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants