Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catppuccin theme #2124

Closed
wants to merge 1 commit into from
Closed

Add Catppuccin theme #2124

wants to merge 1 commit into from

Conversation

WitherCubes
Copy link

@Enselic
Copy link
Collaborator

Enselic commented Mar 28, 2022

I can't find this theme on https://packagecontrol.io/. Is it not there?

@latipun7
Copy link

I can't find this theme on https://packagecontrol.io/. Is it not there?

It's not there yet, I guess. Since the upstream installation guide still manual: https://github.com/catppuccin/sublime-text

@WitherCubes
Copy link
Author

I can't find this theme on https://packagecontrol.io/. Is it not there?

Is it necessarily needed to be packaged?

@Enselic
Copy link
Collaborator

Enselic commented Mar 29, 2022

Normally we require added syntaxes to have 10k downloads to be added. I was mostly curious to know how many downloads this theme had. I've been thinking about this PR some more, and here is how I personally see it.

There are lots of interesting and beautiful themes out there. But we can't add them all to bat, because then it becomes too hard for users to select a theme from the default set of themes.

So I think we should not add this theme to the default set of themes. Instead, we should ensure that it is easy to use custom themes with bat. For example by fixing #2085.

@WitherCubes
Copy link
Author

If it was easy to add custom themes to bat without the hassle of rebuilding the cache, I would be :)

@Enselic
Copy link
Collaborator

Enselic commented Mar 29, 2022

Would you mind if I tested an idea I have on you? Would you like to be able to install themes in the proper place by simply doing bat --install-theme ~/Downloads/some-theme.tmTheme? That would simply copy the theme to $(bat --config-dir)/themes. Maybe it would be too confusing to have that before we fix #2085?

@WitherCubes
Copy link
Author

Would you mind if I tested an idea I have on you? Would you like to be able to install themes in the proper place by simply doing bat --install-theme ~/Downloads/some-theme.tmTheme? That would simply copy the theme to $(bat --config-dir)/themes.

I think that would work for me.

@Enselic
Copy link
Collaborator

Enselic commented Apr 12, 2022

Thank you for the input.

Let's go ahead and close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants