Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored output does not work on cmd.exe (Windows) #129

Closed
jakwings opened this issue Oct 18, 2017 · 3 comments
Closed

Colored output does not work on cmd.exe (Windows) #129

jakwings opened this issue Oct 18, 2017 · 3 comments
Labels

Comments

@jakwings
Copy link
Contributor

Need another colorizer for Windows.

@sharkdp sharkdp changed the title --color=always outputs garbage on Windows cmd.exe Colored output does not work on cmd.exe (Windows) Oct 18, 2017
@sharkdp
Copy link
Owner

sharkdp commented Oct 18, 2017

This has been brought up a few times (see discussion in #29, for example). At the moment, I would like to avoid switching to termcolor because it does not support 256 or RGB colors (this is being worked on, though. See BurntSushi/ripgrep#452).

I might be completely wrong on this, but it's unclear for me if there is a (significant) user base that (a) uses the command line on Windows, (b) is interested in modern command line tools like fd and (c) still uses cmd.exe. I would think that most users that fall into categories (a) and (b) would use PowerShell or Bash on Windows.

@jakwings
Copy link
Contributor Author

A simpler solution is to detect color support and completely disable it on cmd.exe. (how to?)

@sharkdp
Copy link
Owner

sharkdp commented Oct 19, 2017

Yes, that seems like a good option to me.

It might be easier to go the other way and generally disable colors on Windows and to enable them if support is detected. Maybe this is related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants