-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for relative speed as part of exported data? #127
Comments
Seems like a great idea, thank you for the feedback. I'd be glad to take a PR. |
.. but maybe we should export it as "relative time" instead where 1.0 would be the value for the fastest? I think this could be easier to read next to the "Time [ms]" column. What do you think? |
Thank you for being so open about inputs :) For the csv and json, I agree that "Relative time" is the most accurate. I also believe the data should contain the existing two decimal number as displayed in the existing summary. However, with the markdown, the visuals get a bit off as the title is long but the content short. I have been playing with the options and the version I find the most appealing is
I know - I have been a bit cheeky to place it as the first column and to rename it to "Speed" while cutting down to only one decimal, adding an What do you think? To compare, here is an example of placing it next to the Mean column and keeping data as close to the existing implementation as possible
|
First off, independent from this ticket: splitting "Min…Max" into two columns sounds like a good idea! Concerning your examples: The first table looks better, indeed. However, "speed" sounds like I should be looking for the highest value (fastest speed), but As for the lower table. What if the column would be on the very right and would just be labeled "Relative"? |
So something like this?
|
Looks good to me, what do you think? I'd maybe remove the |
Ok - got a version working where markdown spits out the right data 🎉
At the moment, its implemented in a way so that it will sort the table by relative speed. This behaviour makes sense when you want to compare all aspects. But using hyperfine to promote a specific command would probably prefer to keep the sequence as one can set the desired one at the top or bottom. What do you think is the best way of presenting the results? In theory, it could also be decided with a flag, but not sure it's worth the added complexity compared to how this feature is not core to hyperfine. |
Yes, I think I'd prefer the commands to be listed in the original command-line argument order.
Hm, yes. That would be a export-specific option. I think I'd rather keep things simple for now. |
Very well. Im on the case. Actually, its really easy as I just need to avoid the sorting - but I have been having "fun" unfolding the wonders of (i)muteabillity in rust to make relative speed part of the export for the other formats. Great chance to learn :) |
Sounds good. Let me know if you need help :-) |
I went ahead and implemented this in #175 |
Released in v1.6.0. |
@sharkdp Thank you so much. Sorry about the stalling of the progress. |
The CLI output has a really great summary formatted like:
The relative speed provided (
2.93
) is, in my opinion, a major take-a-way when reading speed tests. Unfortunately, this information is not (directly) part of the exported data for markdown, json and csv.Would you be willing to accept a PR adding information about the relative speed to the exported data?
The text was updated successfully, but these errors were encountered: