Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elapsed time to progress bar #581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devonhollowood
Copy link

@devonhollowood devonhollowood commented Oct 21, 2022

I think it's pretty reasonable to have this display by default. If you want to hide it behind an option, though, or you want me to change the format / wording, please let me know!

Fixes #416.

@sharkdp
Copy link
Owner

sharkdp commented Oct 29, 2022

Thank you for your contribution!

Hm. I think the idea of the ticket was to only show this for the very first run. I'm not sure about the added value if we show this always. I think less information might be the better default here. Maybe we could simply replace the "Initial time measurement" message with: "Initial time measurement: {elapsed}"? would that work?

@devonhollowood
Copy link
Author

Maybe we could simply replace the "Initial time measurement" message with: "Initial time measurement: {elapsed}"? would that work?

This doesn't work, because template arguments in the ProgressBar's message don't get substituted. So we need a slightly deeper change. I'll see what I can come up with.

@devonhollowood
Copy link
Author

devonhollowood commented Oct 31, 2022

Okay, I think this should work. Here's a gif of what it looks like on my machine.
hyperfine-time-elapsed

@cblair
Copy link

cblair commented Nov 7, 2023

Still something that would be useful, I was suprised hyperfine didn't have this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add ticking elapsed time on "initial time measurement"
3 participants