Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate licenses of all dependencies #355

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Generate licenses of all dependencies #355

merged 2 commits into from
Mar 11, 2023

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Feb 9, 2023 •
edited
Loading

Fixes #324.

@triallax triallax force-pushed the generate-third-party-licenses branch from 1aa5aa3 to d72b082 Compare February 9, 2023 20:26
@triallax
Copy link
Contributor Author

triallax commented Feb 9, 2023 •
edited
Loading

@sharkdp purescript-pairs, which you own, doesn't have a LICENSE file in its repo and so does not have a license attached to it in the generated license files. Could you please add one? There's purescript/purescript-numbers#25 too, but I'll open a PR for that myself.

@triallax triallax force-pushed the generate-third-party-licenses branch 2 times, most recently from 3dd3f69 to 4ef9c6d Compare February 9, 2023 21:02
@sharkdp
Copy link
Owner

sharkdp commented Feb 10, 2023

@sharkdp purescript-pairs, which you own, doesn't have a LICENSE file in its repo and so does not have a license attached to it in the generated license files. Could you please add one?

Done

sharkdp
sharkdp reviewed Feb 10, 2023
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@triallax
Copy link
Contributor Author

Thank you for working on this!

Sure, you're welcome! This has been bugging me for quite a while, so I'm happy to be making progress on it now.

@triallax
Copy link
Contributor Author

The last dependency without a license file is https://github.com/jcubic/lily (see jcubic/lily#8), but I don't know if we should wait for the maintainer to add one, as this is an urgent PR. Do we just include special-case it and include the text in https://github.com/jcubic/lily#license for now?

@triallax triallax force-pushed the generate-third-party-licenses branch 2 times, most recently from 9b20ff2 to 74be2ef Compare February 26, 2023 20:46
@triallax
Copy link
Contributor Author

@sharkdp could you please cut a new version of purescript-pairs? You haven't made one after you added the license file.

@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2023

Done

@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2023

Do we just include special-case it and include the text in https://github.com/jcubic/lily#license for now?

sounds good

@triallax triallax force-pushed the generate-third-party-licenses branch from 74be2ef to bb8067c Compare March 2, 2023 22:59
@triallax triallax marked this pull request as ready for review March 2, 2023 22:59
@triallax
Copy link
Contributor Author

triallax commented Mar 2, 2023

Should be ready for review/merge now.

@triallax triallax force-pushed the generate-third-party-licenses branch from bb8067c to 2c10285 Compare March 2, 2023 23:01
@triallax triallax force-pushed the generate-third-party-licenses branch from 2c10285 to bf3a47a Compare March 10, 2023 21:49
@triallax
Use separate Spago config for tests
5b1c579 
This will allow us to get the licenses of production dependencies only.
See my next commit.
@triallax
Generate licenses of all dependencies
c4e84e9 
Fixes sharkdp#324.

I also updated the package set for a couple dependencies that did not
have license files in the versions in the older package set.
@triallax triallax force-pushed the generate-third-party-licenses branch from bf3a47a to c4e84e9 Compare March 11, 2023 14:20
@triallax triallax merged commit bf19ccd into sharkdp:master Mar 11, 2023
@triallax triallax deleted the generate-third-party-licenses branch March 11, 2023 14:22
@triallax
Copy link
Contributor Author

@sharkdp please release v5.8.1 on GitHub and npm and update the Insect website when you get the time.

@sharkdp
Copy link
Owner

sharkdp commented Mar 12, 2023

Thank you. I released a new version to npm before checking the npm package somehow. It seems like it doesn't contain the third party licenses. Do we need to add that file to the "files" section in package.json?

@triallax
Copy link
Contributor Author

Yeah, my bad, it should be. I'll open a PR for that real quick.

@sharkdp
Copy link
Owner

sharkdp commented Mar 12, 2023

No worries, thank you very much for working on this!

@triallax
Copy link
Contributor Author

You're welcome.

I guess this means we're going to need to publish a v5.8.2 now? Should we revoke v5.8.1 from npm?

@sharkdp
Copy link
Owner

sharkdp commented Mar 12, 2023

I guess this means we're going to need to publish a v5.8.2 now?

Done.

Should we revoke v5.8.1 from npm?

I don't see a need for that.

@triallax
Copy link
Contributor Author

Alright then.

I was impatient for a new release with this PR to be made so that I could try to package Insect for Void Linux. I'm going to work on that sometime in the near future. :)

@triallax
Copy link
Contributor Author

Small update: before I got to work on packaging Insect, I asked on IRC and unfortunately the Void Linux team said they wouldn't accept it, but at least I saved some effort.

@sharkdp
Copy link
Owner

sharkdp commented Mar 16, 2023

Thank you for the feedback. Any concrete reasons?

@triallax
Copy link
Contributor Author

void-linux/void-packages#11628 (comment)

@sharkdp
Copy link
Owner

sharkdp commented Mar 16, 2023

One possible reason that would be in favor of providing a distribution package over npm: it allows proper installation of things like man pages, desktop files, etc.

@triallax
Copy link
Contributor Author

triallax commented Mar 16, 2023 •
edited
Loading

I don't think that's going to convince them, but having Insect be rewritten in a certain compiled language might. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute all dependencies of Insect
2 participants
@triallax @sharkdp