Implement attributes for the new container limit kinds #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small comments! Looks good to me! Naming is hard. |
Oh man, this is certainly true 😛 I really wish I could come up with something better for these bits/bytes attributes |
These are then used to remove the weird `until` case in the expansion of the proc-macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the attributes for the new limit kinds introduced in the previous PR (#118), taking care of issues #76 and #110.
For #76, I'm conscious of the fact that a decision around the specific attrbute was never reached so I've arbitrarily opted for
bits_readandbytes_readto avoid overloading any existing attributes, though I'm more than happy to change this if we decide something else is better.