Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub Properties Observable & Writer #60

Closed
tthiery opened this issue Jul 15, 2020 · 1 comment
Closed

Hub Properties Observable & Writer #60

tthiery opened this issue Jul 15, 2020 · 1 comment
Assignees
@tthiery
Labels
area-hubs enhancement New feature or request good first issue Good for newcomers
Milestone
v2.1

Comments

@tthiery
Copy link
Member

tthiery commented Jul 15, 2020

See spec which of them are observable and have writers

Lesson Learnt from #51
@tthiery tthiery added enhancement New feature or request area-hubs labels Jul 15, 2020
@tthiery tthiery added this to the v2.1 milestone Jul 15, 2020
@tthiery
Copy link
Member Author

tthiery commented Jul 24, 2020 •
edited
Loading

Properties

  • AdvertisementName (set, request, monitor, reset)
  • Button, RSSI, BatteryVoltage (request, monitor)
  • HwNetworkId (set, reset)
  • HwNetworkFamily (set)

Infrastructure

  • Single observable for all properties
  • Hub.INotifyPropertyChanged for properties
  • Device.PropertyChanged

Request, Monitor on/off via method Hub.SetupNotificationAsync and existing Hub.RequestHubPropertySingleUpdate.

@tthiery tthiery added the good first issue Good for newcomers label Jul 24, 2020
tthiery added a commit that referenced this issue Jul 25, 2020
@tthiery
Add Set/Reset supported Hub Properties
f8fa518 
- Add Example
#60
tthiery added a commit that referenced this issue Jul 25, 2020
@tthiery
Add Guarding to Set and Reset Hub Property
673c167 
#60
tthiery added a commit that referenced this issue Jul 25, 2020
@tthiery
Add observable for all observable hub properties
dd8aa72 
- Add Example for button pressed observing
- Add PropertyChangedObservable
- Add assert for connection on all hub property operations
- Add method to observe properties

#60 non-breaking
tthiery added a commit that referenced this issue Jul 25, 2020
@tthiery
Move HubProperty into central namespace
21cd76c 
- Avoid necessity to access internal namespace

#60 non-breaking (previous namespace was internal)
@tthiery tthiery self-assigned this Jul 25, 2020
tthiery added a commit that referenced this issue Jul 25, 2020
@tthiery
Add guarding for SetupNotification for Hub Properties
8f694cb 
#60 non-breaking
tthiery added a commit that referenced this issue Jul 27, 2020
@tthiery
Add INotifyPropertyChanged
7f9e81d 
#60
@tthiery tthiery closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthiery tthiery

Labels
area-hubs enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
1 participant
@tthiery