Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xamarin support #69

Closed
3 tasks
tthiery opened this issue Jul 28, 2020 · 2 comments · Fixed by #146
Closed
3 tasks

Add Xamarin support #69

tthiery opened this issue Jul 28, 2020 · 2 comments · Fixed by #146
Assignees
Labels
area-bt-xamarin enhancement New feature or request

Comments

@tthiery
Copy link
Member

tthiery commented Jul 28, 2020

  • Find right abstraction library
  • Create assembly for hosting it
  • Create sample app (not in the library project)
@tthiery tthiery added enhancement New feature or request area-bt-xamarin labels Jul 28, 2020
@Berdsen
Copy link
Contributor

Berdsen commented Mar 29, 2021

Hi,
I recently started to write a lego boost xamarin library when I found this awesome project. So I forked it and implemented the Xamarin Bluetooth implementation (based on Plugin.BLE) to be able to use the core lib within xamarin.

I would like to pull reques, but I have some questions. You recently updated the project to .NET 5 but this will be incompatible with Xamarin (Forms). I reworked it already in my feature branch (use latest c# version, targetFramework netstandard2.1, lib project only).

But maybe a better solution would be to have two solution files with one Windows and one Xamarin projects?
Shall I open the pull request to discuss this within the pr itself?

@tthiery
Copy link
Member Author

tthiery commented Mar 29, 2021

Damn. What a unfortunate moment. A months earlier and I would have delayed the whole new tech wave till after .NET 6.

I think the best option is:

  • we create a maintenance release on the 3.x version which will support Xamarin.Forms 5.
  • we stabilize the whole feature there
  • with .NET 6 in November we merge the stuff in the v4+ at that time

Is that acceptable to you? It would lock you out of the mainline for 8+ months. Which is endless and super short at the same time. The other alternatives are duplicate implementions (like suggested but I do not like it) or some magic on the project files and #ifdefs.

I want your contribution!! We just need to find the right way of doing it.

Create the pull so I can have a look. that does not harm!

tthiery pushed a commit that referenced this issue Mar 31, 2021
- Add BLE support for Camaro using BLE.Plugin
- Multi-targeted PoweredUp library to support .NET 5 and .NET Standard 2.1

Closes #69 breaking
@tthiery tthiery added this to the v4.0 (breaking) milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-bt-xamarin enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants