Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoding name now also supports strings without padding nulls. #194

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Decoding name now also supports strings without padding nulls. #194

merged 1 commit into from
Jan 14, 2024

Conversation

mennolodder
Copy link
Contributor

@mennolodder mennolodder commented Jan 14, 2024 •
edited by tthiery
Loading

Added support for messages that fill the full name length.

#193 non-breaking

@mennolodder mennolodder mentioned this pull request Jan 14, 2024
Closed
@tthiery tthiery merged commit f07713c into sharpbrick:master Jan 14, 2024
1 check passed
@tthiery tthiery self-requested a review January 14, 2024 15:45
@tthiery tthiery added the bug Something isn't working label Jan 14, 2024
@tthiery tthiery added this to the v5.0 (breaking) milestone Jan 14, 2024
@mennolodder mennolodder deleted the pullrequest/decode_name_fix branch January 14, 2024 20:52
@mennolodder mennolodder mentioned this pull request Feb 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthiery tthiery Awaiting requested review from tthiery

Assignees

@mennolodder mennolodder

Labels
bug Something isn't working
Projects
None yet
Milestone
v5.0 (breaking)
Development

Successfully merging this pull request may close these issues.
2 participants
@mennolodder @tthiery