Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose ASD loading #7

Open
phoe opened this issue Mar 28, 2020 · 2 comments
Open

Verbose ASD loading #7

phoe opened this issue Mar 28, 2020 · 2 comments

Comments

@phoe
Copy link

phoe commented Mar 28, 2020

cxml/cxml.asd

Lines 13 to 37 in adb4430

(progn
(format t "~&;;; Checking for wide character support...")
(force-output)
(flet ((test (code)
(and (< code char-code-limit) (code-char code))))
(cond
((not (test 50000))
(format t " no, reverting to octet strings.~%")
#+rune-is-character
(error "conflicting unicode configuration. Please recompile.")
(pushnew :rune-is-integer *features*))
((test 70000)
(when (test #xD800)
(format t " WARNING: Lisp implementation doesn't use UTF-16, ~
but accepts surrogate code points.~%"))
(format t " yes, using code points.~%")
#+(or rune-is-integer rune-is-utf-16)
(error "conflicting unicode configuration. Please recompile.")
(pushnew :rune-is-character *features*))
(t
(format t " yes, using UTF-16.~%")
#+(or rune-is-integer (and rune-is-character (not rune-is-utf-16)))
(error "conflicting unicode configuration. Please recompile.")
(pushnew :rune-is-utf-16 *features*)
(pushnew :rune-is-character *features*)))))

This codeblock contributes to (IMO unnecessarily) verbose Quicklisp loads of cxml, for instance:

To load "foo-system":
  Load 1 ASDF system:
    foo-system

; Loading "foo-system"
.
;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points.
 yes, using code points.
..
;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points.
 yes, using code points.
;;; Building Closure with CHARACTER RUNES
...............................................
...................

Is it possible/desired to remove the FORMAT calls altogether?

@luismbo
Copy link
Member

luismbo commented Mar 29, 2020 via email

@phoe
Copy link
Author

phoe commented Mar 29, 2020

This could be explored. ASDF might treat that warning as a compilation error and fail the loading operations though; maybe it would be better to signal a non-warning condition instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants