Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by TCPPoolConfig config; Improve read config file lines; Fix typo #209

Merged
merged 5 commits into from
Feb 19, 2020

Conversation

shawn1m
Copy link
Owner

@shawn1m shawn1m commented Feb 19, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #209 into master will decrease coverage by 8.14%.
The diff coverage is 27.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   42.06%   33.91%   -8.15%     
==========================================
  Files           4       10       +6     
  Lines         233      457     +224     
==========================================
+ Hits           98      155      +57     
- Misses        116      276     +160     
- Partials       19       26       +7
Impacted Files Coverage Δ
core/outbound/clients/resolver/https_resolver.go 0% <0%> (ø)
core/outbound/clients/resolver/tcp_resolver.go 0% <0%> (ø)
core/outbound/clients/resolver/tcptls_resolver.go 0% <0%> (ø)
core/outbound/clients/resolver/address.go 25% <0%> (ø)
core/outbound/dispatcher.go 59% <100%> (+5.59%) ⬆️
core/outbound/clients/resolver/base_resolver.go 33.33% <33.33%> (ø)
core/hosts/hosts.go 68.11% <66.66%> (+1.01%) ⬆️
core/outbound/clients/resolver/udp_resolver.go 77.77% <77.77%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209cc3e...a8ba3b0. Read the comment docs.

@shawn1m shawn1m merged commit 7b81109 into master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant