Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS from keyLabel to characters #13

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

danielroek
Copy link
Collaborator

Changed the MacOS implementation to use characters instead of keyLabel.

@shaxxx
Copy link
Owner

shaxxx commented Feb 17, 2022

Since I don't have time (and this will not change in foreseeable future) to do a decent review I'm merging this.
Since package isn't at version 1.0 now, I believe that it's lesser evil than doing no updates.
And I'm currently without access to MacOS to actually test this.
Just ping me when you think it's time to publish package (now?)

Thank you for hard work.

@shaxxx shaxxx merged commit 3d1e145 into shaxxx:master Feb 22, 2022
@shaxxx
Copy link
Owner

shaxxx commented Feb 22, 2022

@danielroek Is this ready to be published as a package?

@danielroek
Copy link
Collaborator Author

Yes, go ahead @shaxxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants