Implement efficient map iter, fix test bug #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map iteration now uses the reflect package to avoid the alternatives of allocating potentially large slices of keys or strange goroutine trickery which we discussed IRL.
There were iterator tests already, so I kept them as-is.
I did notice a strange test failure due to iterator objects getting re-used across two separate tests, so I fixed that by thunking iterator instantiation, wrapping the iterator construction in parameterless functions.