Create shadow and audit with auatovacuum default #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayonj
commented
Jul 2, 2023
| @@ -81,7 +81,6 @@ def run(connection, query, reuse_trasaction = false, &block) | |||
| connection.block | |||
| logger.info("Exception raised, rolling back query", { rollback: true, query: query }) | |||
| connection.async_exec("ROLLBACK;") | |||
| connection.async_exec("COMMIT;") | |||
There was a problem hiding this comment.
COMMIT isn't needed if a query is being rolled back. Just cleaning up.
Calling an `ALTER` with a transaction open during serializable while we copy data onto the audit table could potentially lead to lock queues. This avoids doing so by removing the `disable_vaccum` function and taking advantage of `WITH` directive when setting up the shadow and audit table in the first place. Thus avoiding the need to perform an `ALTER` on audit table or shadow table and avoid locking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling an
ALTERwith a transaction open during serializable while we copy data onto the audit table could potentially lead to lock queues. This avoids doing so by removing thedisable_vaccumfunction and taking advantage ofWITHdirective when setting up the shadow and audit table in the first place. Thus avoiding the need to perform anALTERon audit table or shadow table and avoid locking.After some good findings from #94
h/t @yash-toddleapp