Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote table name in the VACUUM SQL #118

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Quote table name in the VACUUM SQL #118

merged 2 commits into from
Apr 28, 2024

Conversation

faridco
Copy link
Contributor

@faridco faridco commented Apr 24, 2024

Table name could use reserved keyword from SQL. For example, the following is valid

create table "table" (id int);
insert into "table" (id) values (1);
select * from "table"

NOTE the quoting

@shayonj
Copy link
Owner

shayonj commented Apr 28, 2024

Thank you for the PR. If you don't mind doing a rebase with the main branch. Pushed a fix for the CI failure - 3aade1c

@faridco
Copy link
Contributor Author

faridco commented Apr 28, 2024

Thank you for the PR. If you don't mind doing a rebase with the main branch. Pushed a fix for the CI failure - 3aade1c

I've updated the fork

@shayonj shayonj merged commit 5825f4f into shayonj:main Apr 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants