Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs list does not display master branch when there is more than 1 remote #227

Closed
maks opened this issue Aug 12, 2016 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@maks
Copy link
Collaborator

maks commented Aug 12, 2016

the master branch for any extra remote that are added (after origin) are not displayed in the refs (aka "branches") listview dialog
see:
screenshot_20160812-130034

@maks maks added the bug label Aug 12, 2016
@maks maks added this to the v1.3.3 milestone Aug 12, 2016
@maks
Copy link
Collaborator Author

maks commented Aug 29, 2016

turns out this is due to:

for (Ref ref : remoteRefs) {
String name = ref.getName();
String localName = convertRemoteName(name);
if (branchSet.contains(localName))
continue;
branchList.add(name);

which stops you seeing any remote refs which would end up having the same name locally, its just most obvious with the master branch.

@maks maks self-assigned this Aug 29, 2016
@maks
Copy link
Collaborator Author

maks commented Aug 30, 2016

turns out this is actually a bit more work as need to also change SGits current behaviour of automatically creating a local branch ref and checking it out when a remote ref is selected, rather than checking out the actual remote ref as a detached head the way (canonical) git would.

@maks
Copy link
Collaborator Author

maks commented Nov 2, 2016

This issue was moved to maks/MGit#24

@maks maks closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant