Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View "Item" #79

Closed
DonKoko opened this issue Apr 18, 2023 · 0 comments · Fixed by #83
Closed

View "Item" #79

DonKoko opened this issue Apr 18, 2023 · 0 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Apr 18, 2023

This issue covers the "show" view for the items.
File location: https://github.com/Shelf-nu/shelf.nu/blob/dev/app/routes/_layout%2B/items.%24itemId.tsx
Figma link to this view: https://www.figma.com/file/2XkiKJ4II7Mux6JJL9hYTm/Shelf-App-%7C-Production-Ready?node-id=5340%3A287414&t=rINYxi14vcHB3vyF-1

Most of the content/data you need is already returned by the loader.
The idea is to create the general layout and mostly focus on the information we already have.
Things to skip for now:

  • map
  • notes backend

For the notes part you can just hardcode some content to make the ui look as in the design and I will do the backend part after.
Also what will need to be taken care of is the mobile view. Lets start with desktop first as we need to still figure out some details related to mobile.

@DonKoko DonKoko added the enhancement New feature or request label Apr 18, 2023
@hunar1312 hunar1312 linked a pull request Apr 21, 2023 that will close this issue
@hunar1312 hunar1312 mentioned this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants