-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for 527K - Dyson Pure Hot+Cool Formaldehyde #175
base: main
Are you sure you want to change the base?
Conversation
I've added a second commit fixing the class and unit of the formaldehyde sensor, which were not being seen by HA as a measurement class. Feel free to reject that second commit if that was setup that way on purpose, but I suspect it wasn't intentional. |
Great work! Hoping to see this merged soon. Been waiting for Formaldehyde sensor support for my TP09 :) |
It should be easy to apply this (and related PR to libdyson) by hand on your system in the mean time, if you don't want to wait |
It seems I get the following. I've seen others with this in the issues section. Platform not found (cannot import name 'DysonPureHotCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.10/site-packages/libdyson/init.py)). |
Yeah you need to patch your libdyson with the content of that PR first, the code here depends on the lib already supporting the fan |
Gotcha, thank you. I made that change and the error is gone, but I do not see the HCHO sensor appear. I made sure the changes I added from your diff are in my sensor.py and that manifest.json points to the new lib like your previous comment. I've tried reloading the device and rebooting HA. Maybe I missed something. Guessing maybe the isinstance isn't picking up my TP09. I'll have to see where the model info is stored so I can change it if is incorrect Update: @Ulrar it seems it was the isinstance since mine is a DysonPureCoolFormaldehyde and doesn't have heat. After importing that and adding an isinstance check for it, it's working as expected. Thanks again, and Happy Holidays! |
Ah yes, that's a different device. |
@Ulrar , I get libdyson.exceptions.DysonInvalidAuth when trying to use get_devices.py, similar to this post. I have a Dyson Pure Cool Formaldehyde TP09. Modifying your changes to the following allow me to see the HCHO readings in HA that match my TP09
I'm not sure what the best way to add it is since you have a PR pending. I can branch from your branch, or you can add, either way :P |
Ah sorry, completely missed this. Ideally you wouldn't just use this PR as is, since your device doesn't have heating, but we can add another instance without heating for that product code, assuming that's the right one. |
@Ulrar i have a HP09, got the serial and the credentials via libdyson. How can i solve that? |
Have you made the changes to libdyson as well? |
No worries.
Yes, that is correct. I've been using the changes I mentioned above without issue for a couple weeks now. |
@Ulrar @dustingrady do you also use HomeAssistant? Cause i cant find the libdyson folder in HomeAssistant, i've done the changes in dyson-local files. |
Yeah but I don't use Hass OS so I can't talk to it, I just use the docker container. |
I have created a fork of libdyson and added the code of @Ulrar into the fork so everyone can use it directly untill the maintainer of dyson-local merges Ulrar's code source = shenxn/libdyson@6a8ed5c#diff-ef0658f150dc67e06f245eb9a355b958562f9f9cc24c8360f3e8c54417b7c3c2 In HomeAssistant edit /config/custom_components/dyson_local/manifest.json Restart HomeAssistant and add the Hot+Cool Formaldehyde via local method |
Is the main project we're branching from still supported? I haven't seen any merges recently by the author. |
Support for both 527K devices (Formaldehyde and non-Formaldehyde) has been implemented on https://github.com/libdyson-wg/ha-dyson and https://github.com/libdyson-wg/libdyson-neon @dustingrady sadly, while we're grateful for shenxn's building of the foundation, they are no longer active. the ha-dyson fork has been created to continue development of these projects. |
This adds support for the Dyson Pure Hot+Cool Formaldehyde (527K).
This depends on shenxn/libdyson#36.
This solves #167