fix: DataChannel not emitting new data on iOS

[tamimattafi]

Problem

In our project, we use data channels to notify other peers that some state has changed (mic, camera, and other stuff)

On iOS, data channels work for 4-5s after the connection is established then they stop emitting data in onMessage flow, while sending data still works properly (Only receiving data was broken)

After digging a little deeper in the app, I found out that my collectors (subscription to data flow) are always active, they just don't receive anything. This applies to all flows (onMessage, onClose...)

It seemed like an internal problem in webrtc, so I cloned the library and started logging and making some changes. I found out that the delegate stops receiving callbacks after a short time, which looks like something is reassigning it, or it's getting cleared somewhere.

Solution

This solution might be weird, but it works. Before making these changes, I could repeat the problem 10 times out of 10, but after the changes, I couldn't repeat it anymore.

I think having a strong reference of the delegate prevents it from being cleared, therefore it's always active.

I would love to hear your thoughts on this :)

[tamimattafi]

@shepeliev Hello! Is there a possibility to have a review for this PR?

[shepeliev]

Hi, @tamimattafi!

Thank you for PR.

LGTM.

[tamimattafi]

@shepeliev Thank you! Looking forward to have this in upcoming patches :)